Don't include debugging symbols in XHPAST by default
ClosedPublic
Actions

Authored by joshuaspence on Jul 8 2015, 7:31 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU361c81c2960e: Don't include debugging symbols in XHPAST by default

Summary

I'm not C/C++ expert, but it seems odd to me that we include debugging symbols on a normal xhpast build... doesn't this have some performance overhead?

Test Plan

N/A

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 32854.Jul 8 2015, 7:31 AM

joshuaspence retitled this revision from to Don't include debugging symbols in XHPAST by default.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 8 2015, 7:31 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Running a simple script to investigate the impact of this change:

#!/bin/bash

rm -f src/.phutil_module_cache
./scripts/build_xhpast.php
time ./scripts/phutil_rebuild_map.php src

Before

real	0m26.442s
user	1m1.528s
sys	0m10.568s

After

real	0m21.172s
user	0m59.420s
sys	0m9.676s

epriestley accepted this revision.Jul 8 2015, 7:38 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 8 2015, 7:38 AM

Closed by commit rPHU361c81c2960e: Don't include debugging symbols in XHPAST by default (authored by joshuaspence, committed by joshuaspence). · Explain WhyJul 8 2015, 8:28 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

support/

xhpast/

Makefile

2 lines

Diff 32855

View Options

Don't include debugging symbols in XHPAST by defaultClosedPublicActions