Paths

Table of Contentst

Differential D13595

Minor performance optimization
ClosedPublic
Actions

Authored by joshuaspence on Jul 8 2015, 7:29 AM.

Tags

None

Referenced Files

	F13209570: D13595.diff
	Fri, May 17, 12:58 AM

	F13205496: D13595.diff
	Wed, May 15, 2:00 AM

	F13187705: D13595.diff
	Sat, May 11, 4:42 AM

	Unknown Object (File)
	Tue, May 7, 7:53 AM

	Unknown Object (File)
	Fri, May 3, 7:33 AM

	Unknown Object (File)
	Thu, Apr 25, 1:37 AM

	Unknown Object (File)
	Apr 11 2024, 9:19 AM

	Unknown Object (File)
	Apr 7 2024, 6:59 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARC23a653e2bbad: Minor performance optimization

Summary

Avoid using idx in PhutilTestCase::endCoverage.

Test Plan

Compared before and after.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 7201
Build 7446: [Placeholder Plan] Wait for 30 Seconds
Build 7445: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	87 ms	PhpunitTestEngineTestCase::Unknown Unit Message ("")
	2,563 ms	ArcanistLibraryTestCase::Unknown Unit Message ("")
	285 ms	ArcanistLibraryTestCase::Unknown Unit Message ("")
	83 ms	ArcanistLibraryTestCase::Unknown Unit Message ("")
	56 ms	PhutilUnitTestEngineTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 8 Passed)

Event Timeline

joshuaspence updated this revision to Diff 32853.Jul 8 2015, 7:29 AM

joshuaspence retitled this revision from to Minor performance optimization.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 8 2015, 7:29 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Jul 8 2015, 7:32 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 8 2015, 7:32 AM

Closed by commit rARC23a653e2bbad: Minor performance optimization (authored by joshuaspence, committed by joshuaspence). · Explain WhyJul 8 2015, 8:32 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

unit/

engine/

phutil/

PhutilTestCase.php

5 lines

55%

Loading...

Diff 32853

src/unit/engine/phutil/PhutilTestCase.php

Loading...