Page MenuHomePhabricator
Differential D13595

Minor performance optimization
ClosedPublic
Actions

Authored by joshuaspence on Jul 8 2015, 7:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 27, 8:33 AM
Unknown Object (File)
Mon, Jan 27, 3:11 AM
Unknown Object (File)
Mon, Jan 27, 3:11 AM
Unknown Object (File)
Mon, Jan 27, 3:11 AM
Unknown Object (File)
Mon, Jan 27, 2:58 AM
Unknown Object (File)
Fri, Jan 24, 7:32 AM
Unknown Object (File)
Fri, Jan 24, 7:32 AM
Unknown Object (File)
Fri, Jan 24, 7:32 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC23a653e2bbad: Minor performance optimization
Summary

Avoid using idx in PhutilTestCase::endCoverage.

Test Plan

Compared before and after.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 7201
Build 7446: [Placeholder Plan] Wait for 30 Seconds
Build 7445: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
87 msPhpunitTestEngineTestCase::Unknown Unit Message ("")
2,563 msArcanistLibraryTestCase::Unknown Unit Message ("")
285 msArcanistLibraryTestCase::Unknown Unit Message ("")
83 msArcanistLibraryTestCase::Unknown Unit Message ("")
56 msPhutilUnitTestEngineTestCase::Unknown Unit Message ("")
View Full Test Results (1 Failed · 8 Passed)

Event Timeline

joshuaspence updated this revision to Diff 32853.Jul 8 2015, 7:29 AM
joshuaspence retitled this revision from to Minor performance optimization.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 8 2015, 7:29 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jul 8 2015, 7:32 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 8 2015, 7:32 AM
Closed by commit rARC23a653e2bbad: Minor performance optimization (authored by joshuaspence, committed by joshuaspence). · Explain WhyJul 8 2015, 8:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
unit/
engine/
phutil/
5 lines55%
Loading...

Diff 32853

View Options

src/unit/engine/phutil/PhutilTestCase.php

Loading...
Phabricator · Built by Phacility