Optimize ArcanistXHPASTLinterRule::getLintID.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARCbbccf1dd4059: Linter performance optimization
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- master
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 7166 Build 7377: [Placeholder Plan] Wait for 30 Seconds Build 7376: arc lint + arc unit
Event Timeline
Comment Actions
For consistency, prefer lintID.
It looks like getLintSeverity in the parent is also maybe cacheable? It's building a map every time and mpull'ing it? Caching that might make this moot.
Comment Actions
Cache ArcanistXHPASTLinter::getLintNameMap and ArcanistXHPASTLinter::getLintSeverityMap