Page MenuHomePhabricator
Differential D13541

Linter performance optimization
ClosedPublic
Actions

Authored by joshuaspence on Jul 3 2015, 3:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 31, 10:06 AM
Unknown Object (File)
Thu, May 29, 6:01 PM
Unknown Object (File)
Thu, May 29, 2:15 PM
Unknown Object (File)
Tue, May 27, 4:54 AM
Unknown Object (File)
Mon, May 26, 9:42 PM
Unknown Object (File)
Sat, May 24, 10:13 PM
Unknown Object (File)
Thu, May 8, 4:56 AM
Unknown Object (File)
Tue, May 6, 5:55 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCbbccf1dd4059: Linter performance optimization
Summary

Optimize ArcanistXHPASTLinterRule::getLintID.

Test Plan

Compare before and after.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7166
Build 7377: [Placeholder Plan] Wait for 30 Seconds
Build 7376: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 32721.Jul 3 2015, 3:05 PM
joshuaspence retitled this revision from to Linter performance optimization.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 3 2015, 3:05 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jul 3 2015, 3:21 PM
epriestley edited edge metadata.

For consistency, prefer lintID.

It looks like getLintSeverity in the parent is also maybe cacheable? It's building a map every time and mpull'ing it? Caching that might make this moot.

This revision is now accepted and ready to land.Jul 3 2015, 3:21 PM
joshuaspence updated this revision to Diff 32791.Jul 7 2015, 8:05 AM
joshuaspence edited edge metadata.

Cache ArcanistXHPASTLinter::getLintNameMap and ArcanistXHPASTLinter::getLintSeverityMap

Closed by commit rARCbbccf1dd4059: Linter performance optimization (authored by joshuaspence, committed by joshuaspence). · Explain WhyJul 7 2015, 8:05 AM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in D13646: Make Herald action modularization more aggressive.Jul 18 2015, 1:49 AM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
lint/
linter/
21 lines94%
Loading...
xhpast/
40 lines81%
Loading...

Diff 32791

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php

Loading...
Phabricator · Built by Phacility