Ref T8726.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T8726: Modularize Herald fields and actions
- Commits
- Restricted Diffusion Commit
rP98ac0a022c90: Modularize all Diffusion commit Herald fields
Created a giant rule with every commit field:
Ran the upgrade, got the same rule with new fields:
Used "Test Console" to run transcripts, saw all the fields populate correctly.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- hmodular10
- Lint
Lint Errors Severity Location Code Message Error src/applications/conpherence/query/ConpherenceThreadSearchEngine.php:21 PHL1 Unknown Symbol - Unit
Tests Passed - Build Status
Buildable 7164 Build 7373: [Placeholder Plan] Wait for 30 Seconds Build 7372: arc lint + arc unit
Event Timeline
Comment Actions
I think 20150706.herald.1.sql is the MVP of this diff, possibly HeraldSubscribersField.php since it got to be the "parent of" (copied to) basically every other file.