Page MenuHomePhabricator
Differential D13567

Modularize all Diffusion commit Herald fields
ClosedPublic
Actions

Authored by epriestley on Jul 6 2015, 9:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 24, 5:39 PM
Unknown Object (File)
Fri, Dec 20, 12:10 PM
Unknown Object (File)
Sun, Dec 15, 9:41 PM
Unknown Object (File)
Sun, Dec 8, 3:19 PM
Unknown Object (File)
Sat, Dec 7, 2:43 PM
Unknown Object (File)
Nov 27 2024, 9:42 PM
Unknown Object (File)
Nov 26 2024, 1:02 AM
Unknown Object (File)
Nov 19 2024, 5:01 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8726: Modularize Herald fields and actions
Commits
Restricted Diffusion Commit
rP98ac0a022c90: Modularize all Diffusion commit Herald fields
Summary

Ref T8726.

Test Plan

Created a giant rule with every commit field:

Screen Shot 2015-07-06 at 1.57.11 PM.png (1×1 px, 271 KB)

Ran the upgrade, got the same rule with new fields:

Screen Shot 2015-07-06 at 2.08.34 PM.png (1×1 px, 268 KB)

Used "Test Console" to run transcripts, saw all the fields populate correctly.

Diff Detail

Repository
rP Phabricator
Branch
hmodular10
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/applications/conpherence/query/ConpherenceThreadSearchEngine.php:21PHL1Unknown Symbol
Unit
Tests Passed
Build Status
Buildable 7164
Build 7373: [Placeholder Plan] Wait for 30 Seconds
Build 7372: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32788.Jul 6 2015, 9:15 PM
epriestley retitled this revision from to Modularize all Diffusion commit Herald fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8726: Modularize Herald fields and actions.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 6 2015, 9:15 PM
btrahan accepted this revision.Jul 7 2015, 6:36 PM
btrahan edited edge metadata.

I think 20150706.herald.1.sql is the MVP of this diff, possibly HeraldSubscribersField.php since it got to be the "parent of" (copied to) basically every other file.

This revision is now accepted and ready to land.Jul 7 2015, 6:36 PM
Closed by commit rP98ac0a022c90: Modularize all Diffusion commit Herald fields (authored by epriestley, committed by epriestley). · Explain WhyJul 7 2015, 6:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
133 lines
src/
44 lines
applications/
diffusion/
herald/
24 lines
26 lines
38 lines
24 lines
24 lines
24 lines
24 lines
9 lines
24 lines
37 lines
24 lines
40 lines
30 lines
diffusion/
herald/
subscriptions/
herald/
DiffusionCommitAuthorHeraldField.php
HeraldSubscribersField.php
18 lines
DiffusionCommitCommitterHeraldField.php
HeraldSubscribersField.php
18 lines
21 lines
DiffusionCommitPackageHeraldField.php
HeraldSubscribersField.php
17 lines
16 lines
DiffusionCommitReviewerHeraldField.php
HeraldSubscribersField.php
18 lines
22 lines
21 lines
diffusion/
herald/
herald/
adapter/
166 lines
herald/
adapter/
field/
19 lines
maniphest/
herald/
8 lines
subscriptions/
herald/
2 lines

Diff 32788

View Options

resources/sql/autopatches/20150706.herald.1.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitAffectedFilesHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitAuthorHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitAutocloseHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitBranchesHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitCommitterHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitDiffContentAddedHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitDiffContentHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitDiffContentRemovedHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitDiffEnormousHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitMessageHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitPackageAuditHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitPackageHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitPackageOwnerHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitRepositoryHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitRepositoryProjectsHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitReviewerHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitRevisionAcceptedHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitRevisionHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitRevisionReviewersHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitRevisionSubscribersHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/HeraldCommitAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldCommitAdapter.php

Loading...
View Options

src/applications/herald/field/HeraldField.php

Loading...
View Options

src/applications/maniphest/herald/ManiphestTaskAssigneeHeraldField.php

Loading...
View Options

src/applications/subscriptions/herald/HeraldSubscribersField.php

Loading...
Phabricator · Built by Phacility