Page MenuHomePhabricator

Modularize all Diffusion commit Herald fields
ClosedPublic

Authored by epriestley on Jul 6 2015, 9:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 1:47 PM
Unknown Object (File)
Mon, Mar 25, 1:47 PM
Unknown Object (File)
Tue, Mar 19, 5:59 PM
Unknown Object (File)
Wed, Mar 13, 11:56 AM
Unknown Object (File)
Sun, Mar 10, 8:15 PM
Unknown Object (File)
Feb 9 2024, 12:11 PM
Unknown Object (File)
Feb 9 2024, 11:17 AM
Unknown Object (File)
Feb 3 2024, 5:44 AM
Subscribers

Details

Summary

Ref T8726.

Test Plan

Created a giant rule with every commit field:

Screen Shot 2015-07-06 at 1.57.11 PM.png (1×1 px, 271 KB)

Ran the upgrade, got the same rule with new fields:

Screen Shot 2015-07-06 at 2.08.34 PM.png (1×1 px, 268 KB)

Used "Test Console" to run transcripts, saw all the fields populate correctly.

Diff Detail

Repository
rP Phabricator
Branch
hmodular10
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/applications/conpherence/query/ConpherenceThreadSearchEngine.php:21PHL1Unknown Symbol
Unit
Tests Passed
Build Status
Buildable 7164
Build 7373: [Placeholder Plan] Wait for 30 Seconds
Build 7372: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modularize all Diffusion commit Herald fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

I think 20150706.herald.1.sql is the MVP of this diff, possibly HeraldSubscribersField.php since it got to be the "parent of" (copied to) basically every other file.

This revision is now accepted and ready to land.Jul 7 2015, 6:36 PM
This revision was automatically updated to reflect the committed changes.