Page MenuHomePhabricator

Modularize all remaining Maniphest Herald fields
ClosedPublic

Authored by epriestley on Jul 1 2015, 12:51 AM.
Tags
None
Referenced Files
F13309423: D13501.diff
Mon, Jun 10, 10:11 AM
F13308017: D13501.id32784.diff
Sun, Jun 9, 11:59 PM
F13288477: D13501.id32784.diff
Tue, Jun 4, 10:30 AM
F13277875: D13501.diff
Fri, May 31, 2:49 PM
F13274474: D13501.diff
Fri, May 31, 3:44 AM
F13260520: D13501.diff
Mon, May 27, 12:01 AM
F13242957: D13501.diff
Thu, May 23, 3:13 AM
F13235350: D13501.id32672.diff
Tue, May 21, 4:45 AM

Details

Summary

Ref T8726. The only notable bit here is that the "body" / "title" fields (which are currently shared across a bunch of types) are getting split into application variants.

Among other things, this will let us label the field "Commit message" for commits, for example.

Test Plan
  • Created a rule using all four fields.
  • Applied patch, saw rule break ("unknown field").
  • Ran storage upgrade, saw rule fix itself in the migration.
  • Edited tasks, triggered rule, viewed transcripts.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modularize all remaining Maniphest Herald fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Use more general field constants and class names.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2015, 5:27 PM
This revision was automatically updated to reflect the committed changes.