Page MenuHomePhabricator

Modularize all remaining Maniphest Herald fields
ClosedPublic

Authored by epriestley on Jul 1 2015, 12:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 13, 4:12 PM
Unknown Object (File)
Feb 23 2024, 7:45 PM
Unknown Object (File)
Feb 9 2024, 5:17 AM
Unknown Object (File)
Feb 3 2024, 5:34 AM
Unknown Object (File)
Jan 24 2024, 11:07 PM
Unknown Object (File)
Jan 5 2024, 3:37 PM
Unknown Object (File)
Dec 29 2023, 11:57 PM
Unknown Object (File)
Dec 26 2023, 3:55 PM

Details

Summary

Ref T8726. The only notable bit here is that the "body" / "title" fields (which are currently shared across a bunch of types) are getting split into application variants.

Among other things, this will let us label the field "Commit message" for commits, for example.

Test Plan
  • Created a rule using all four fields.
  • Applied patch, saw rule break ("unknown field").
  • Ran storage upgrade, saw rule fix itself in the migration.
  • Edited tasks, triggered rule, viewed transcripts.

Diff Detail

Repository
rP Phabricator
Branch
hmodular7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7080
Build 7212: [Placeholder Plan] Wait for 30 Seconds
Build 7211: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modularize all remaining Maniphest Herald fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Use more general field constants and class names.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2015, 5:27 PM
This revision was automatically updated to reflect the committed changes.