Paths

Table of Contentst

Differential D13531

Allow unit test duration to be submitted as a float or an int
ClosedPublic
Actions

Authored by epriestley on Jul 2 2015, 8:58 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8736: Unit tests failed but not submitted

Commits

Restricted Diffusion Commit
rP9623f9b5cf8a: Allow unit test duration to be submitted as a float or an int

Summary

Fixes T8736. It's OK for duration to be something that comes out of JSON as an int, like 1.

Test Plan

Will make @hach-que verify.

Diff Detail

Repository

rP Phabricator

Branch

unit1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7119
Build 7290: [Placeholder Plan] Wait for 30 Seconds
Build 7289: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32705.Jul 2 2015, 8:58 PM

epriestley retitled this revision from to Allow unit test duration to be submitted as a float or an int.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8736: Unit tests failed but not submitted.

epriestley added a subscriber: hach-que.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 2 2015, 8:58 PM

btrahan accepted this revision.Jul 2 2015, 9:20 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jul 2 2015, 9:20 PM

Closed by commit rP9623f9b5cf8a: Allow unit test duration to be submitted as a float or an int (authored by epriestley, committed by epriestley). · Explain WhyJul 2 2015, 9:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

storage/

build/

HarbormasterBuildUnitMessage.php

4 lines

Diff 32705

View Options

src/applications/harbormaster/storage/build/HarbormasterBuildUnitMessage.php

Allow unit test duration to be submitted as a float or an intClosedPublicActions