Paths

Table of Contentst

Allow unit test duration to be submitted as a float or an int
ClosedPublic
Actions

Authored by epriestley on Jul 2 2015, 8:58 PM.

Tags

None

Referenced Files

	F15532779: D13531.id32708.diff
	Wed, Apr 23, 5:15 PM

	F15530945: D13531.diff
	Wed, Apr 23, 8:39 AM

	F15529672: D13531.id.diff
	Tue, Apr 22, 9:38 PM

	F15514320: D13531.id32708.diff
	Fri, Apr 18, 1:56 AM

	F15503917: D13531.diff
	Mon, Apr 14, 2:27 PM

	F15502377: D13531.id32705.diff
	Mon, Apr 14, 12:13 AM

	F15500757: D13531.id.diff
	Sun, Apr 13, 7:09 PM

	F15489034: D13531.id32705.diff
	Fri, Apr 11, 5:29 AM

View All Files

Subscribers

epriestley

hach-que

Details

Reviewers

btrahan

Maniphest Tasks

T8736: Unit tests failed but not submitted

Commits

Restricted Diffusion Commit
rP9623f9b5cf8a: Allow unit test duration to be submitted as a float or an int

Summary

Fixes T8736. It's OK for duration to be something that comes out of JSON as an int, like 1.

Test Plan

Will make @hach-que verify.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32705.Jul 2 2015, 8:58 PM

epriestley retitled this revision from to Allow unit test duration to be submitted as a float or an int.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8736: Unit tests failed but not submitted.

epriestley added a subscriber: hach-que.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 2 2015, 8:58 PM

btrahan accepted this revision.Jul 2 2015, 9:20 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jul 2 2015, 9:20 PM

Closed by commit rP9623f9b5cf8a: Allow unit test duration to be submitted as a float or an int (authored by epriestley, committed by epriestley). · Explain WhyJul 2 2015, 9:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

storage/

build/

HarbormasterBuildUnitMessage.php

4 lines

Diff 32708

View Options

src/applications/harbormaster/storage/build/HarbormasterBuildUnitMessage.php

Allow unit test duration to be submitted as a float or an intClosedPublicActions