This maybe fixes T8576. Whilst running ./bin/search index --all I noticed that I ended up with 159,596 temporary directory which I believe are due to phutil_console_get_terminal_width() running too often.
Details
Details
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- master
- Lint
Lint Passed Severity Location Code Message Advice src/console/format.php:190 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 7102 Build 7256: [Placeholder Plan] Wait for 30 Seconds Build 7255: arc lint + arc unit
Event Timeline
Comment Actions
Technically, we should listen for SIGWINCH (I think) and dirty this cache (because the user may resize the console while running the command), but this behavior is clearly worlds better than the prior behavior.
Comment Actions
Possibly we should do some false vs null stuff so that we cache "it didn't work", too, but whatevs.