Cache terminal width
ClosedPublic
Actions

Authored by joshuaspence on Jul 1 2015, 10:06 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6646: phutil_console_get_terminal_width failing intermittently when left to its own devices inside a screen session
T8576: Indexing search documents uses a lot of memory

Commits

rPHU83f09f6c5a03: Cache terminal width

Summary

This maybe fixes T8576. Whilst running ./bin/search index --all I noticed that I ended up with 159,596 temporary directory which I believe are due to phutil_console_get_terminal_width() running too often.

Test Plan

N/A

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/console/format.php:190	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 7102
Build 7256: [Placeholder Plan] Wait for 30 Seconds
Build 7255: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 32683.Jul 1 2015, 10:06 PM

joshuaspence retitled this revision from to Cache terminal width.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T8576: Indexing search documents uses a lot of memory.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 1 2015, 10:06 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Technically, we should listen for SIGWINCH (I think) and dirty this cache (because the user may resize the console while running the command), but this behavior is clearly worlds better than the prior behavior.

This revision is now accepted and ready to land.Jul 1 2015, 10:08 PM

Closed by commit rPHU83f09f6c5a03: Cache terminal width (authored by joshuaspence, committed by joshuaspence). · Explain WhyJul 1 2015, 10:08 PM

This revision was automatically updated to reflect the committed changes.