Paths

Table of Contentst

Differential D13389

Ensure that a space is used after a catch token
ClosedPublic
Actions

Authored by joshuaspence on Jun 22 2015, 1:07 PM.

Tags

None

Referenced Files

	F13286143: D13389.diff
	Tue, Jun 4, 6:43 AM

	F13273188: D13389.diff
	Fri, May 31, 1:40 AM

	F13249095: D13389.id32409.diff
	Fri, May 24, 6:39 AM

	F13237195: D13389.id32489.diff
	Tue, May 21, 12:57 PM

	F13231805: D13389.diff
	Tue, May 21, 12:46 AM

	F13210759: D13389.diff
	Fri, May 17, 5:11 AM

	F13194688: D13389.diff
	Sun, May 12, 9:47 PM

	F13177450: D13389.diff
	Wed, May 8, 7:43 PM

View All 90 Files

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARC04d788c79ed4: Ensure that a space is used after a catch token

Summary

For consistency, a single space should separate catch and the following parenthetical expression.

Test Plan

Added test case.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 6937
Build 6959: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	2,796 ms	ArcanistJSHintLinterTestCase::testLinter
	1,135 ms	ArcanistCSSLintLinterTestCase::testLinter
	88 ms	ArcanistCSSLintLinterTestCase::testVersion
	14 ms	ArcanistChmodLinterTestCase::testLinter
	218 ms	ArcanistClosureLinterTestCase::testLinter
		View Full Test Results (1 Failed · 48 Passed · 9 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 32409.Jun 22 2015, 1:07 PM

joshuaspence retitled this revision from to Ensure that a space is used after a catch token.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 22 2015, 1:07 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Jun 22 2015, 1:11 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 22 2015, 1:11 PM

Closed by commit rARC04d788c79ed4: Ensure that a space is used after a catch token (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 24 2015, 9:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

xhpast/

space-after-control-keywords.lint-test

5 lines

xhpast/

rules/

ArcanistControlStatementSpacingXHPASTLinterRule.php

1 line

Diff 32409

src/lint/linter/tests/xhpast/space-after-control-keywords.lint-test

Loading...

src/lint/linter/xhpast/rules/ArcanistControlStatementSpacingXHPASTLinterRule.php

Loading...