Paths

Table of Contentst

Differential D13389

Ensure that a space is used after a catch token
ClosedPublic
Actions

Authored by joshuaspence on Jun 22 2015, 1:07 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC04d788c79ed4: Ensure that a space is used after a catch token

Summary

For consistency, a single space should separate catch and the following parenthetical expression.

Test Plan

Added test case.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 32409.Jun 22 2015, 1:07 PM

joshuaspence retitled this revision from to Ensure that a space is used after a catch token.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 22 2015, 1:07 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Jun 22 2015, 1:11 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 22 2015, 1:11 PM

Closed by commit rARC04d788c79ed4: Ensure that a space is used after a catch token (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 24 2015, 9:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

xhpast/

space-after-control-keywords.lint-test

5 lines

xhpast/

rules/

ArcanistControlStatementSpacingXHPASTLinterRule.php

1 line

Diff 32489

View Options

src/lint/linter/tests/xhpast/space-after-control-keywords.lint-test

View Options

src/lint/linter/xhpast/rules/ArcanistControlStatementSpacingXHPASTLinterRule.php

Ensure that a space is used after a catch tokenClosedPublicActions