Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARC3c3438714b43: Further improvements to test discovery
Added to existing test cases.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- master
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 6735 Build 6757: [Placeholder Plan] Wait for 30 Seconds
| Time | Test | |
|---|---|---|
| 5 ms | PhpunitTestEngineTestCase::testSearchLocations | |
| 21 ms | ArcanistLibraryTestCase::testEverythingImplemented | |
| 38 ms | ArcanistLibraryTestCase::testLibraryMap | |
| 40 ms | ArcanistLibraryTestCase::testMethodVisibility | |
| 1 ms | PhutilUnitTestEngineTestCase::testFailSkip | |
| View Full Test Results (1 Failed · 8 Passed) |
Event Timeline
Comment Actions
Since the complexity mostly arises out of dirname()'s behavior being a bit of a mess, maybe this would be cleaner:
- Update PhabricatorFilesystem::walkToRoot() to take a second parameter (like $root) which specifies a parent directory where iteration should stop.
- Get some test coverage on that, since it'll be easy to test properly outside of need to do a bunch of unit test stuff (e.g., path same as root, path outside root, path a symlink into root).
- Replace the manual directory fiddling here with walkToRoot().
I think that would make this a bit simpler and less error prone.
| src/unit/engine/PhutilUnitTestEngine.php | ||
|---|---|---|
| 199–200 | Do we now sometimes end up with the key libname:. and sometimes with the key libname: for root tests? | |
| 214–215 | The unlikely path 0 will do the wrong thing here (output will be __tests__/, should be 0/__tests__/). | |