Page MenuHomePhabricator
Differential D13201

Fix method visibilities
ClosedPublic
Actions

Authored by joshuaspence on Jun 8 2015, 8:40 AM.
Tags
None
Referenced Files
F13119259: D13201.diff
Mon, Apr 29, 2:56 PM
Unknown Object (File)
Thu, Apr 25, 7:03 PM
Unknown Object (File)
Thu, Apr 25, 7:03 PM
Unknown Object (File)
Wed, Apr 24, 10:51 PM
Unknown Object (File)
Sun, Apr 21, 3:06 AM
Unknown Object (File)
Sun, Apr 14, 12:53 AM
Unknown Object (File)
Tue, Apr 9, 4:53 PM
Unknown Object (File)
Tue, Apr 2, 8:13 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPaf1b586990a7: Fix method visibilities
Summary

See also D13186.

Test Plan

Ran arc unit --everything

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 31904.Jun 8 2015, 8:40 AM
joshuaspence retitled this revision from to Fix method visibilities.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 8 2015, 8:40 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jun 8 2015, 8:45 PM
epriestley edited edge metadata.

I miiiight have already fixed this in followups.

This revision is now accepted and ready to land.Jun 8 2015, 8:45 PM
joshuaspence added a comment.Jun 8 2015, 9:14 PM

Nope, looks like you made it worse :P

epriestley added a comment.Jun 8 2015, 9:14 PM

oh good

I am special

joshuaspence updated this revision to Diff 31942.Jun 8 2015, 9:14 PM
joshuaspence edited edge metadata.

Rebase

epriestley added a comment.Jun 8 2015, 9:14 PM

wow I made it a lot worse

joshuaspence added a comment.Jun 8 2015, 9:16 PM

I'll try to finish off D13185 today (which is sort of okay as is, but I want to improve it after D13202 lands).

Closed by commit rPaf1b586990a7: Fix method visibilities (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 8 2015, 9:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
query/
2 lines
files/
query/
2 lines
harbormaster/
query/
2 lines
macro/
query/
2 lines
people/
query/
2 lines
pholio/
query/
2 lines
project/
query/
2 lines
repository/
query/
2 lines

Diff 31944

View Options

src/applications/almanac/query/AlmanacServiceQuery.php

Loading...
View Options

src/applications/files/query/PhabricatorFileSearchEngine.php

Loading...
View Options

src/applications/harbormaster/query/HarbormasterBuildPlanSearchEngine.php

Loading...
View Options

src/applications/macro/query/PhabricatorMacroSearchEngine.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleSearchEngine.php

Loading...
View Options

src/applications/pholio/query/PholioMockSearchEngine.php

Loading...
View Options

src/applications/project/query/PhabricatorProjectSearchEngine.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositorySearchEngine.php

Loading...
Phabricator · Built by Phacility