lose help cursor on blur
ClosedPublic
Actions

Authored by avivey on Jun 12 2015, 4:19 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8501: Cursor stuck in 'help' mode after Ctrl+F

Commits

Restricted Diffusion Commit
rP960a574dd538: lose help cursor on blur

Summary

Fixes T8501.
When losing focus while holding ctrl, we never get a key-up event; ctrl-f/d/tab make the browser tab lose focus.
So treat 'blur' (unfocus) as if the user released ctrl.

Test Plan

ctrl-f/ctrl-d/ctrl-tab, ctrl-click-outside-of-window, and move mouse over the content - see no help suggestions.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6702
Build 6724: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

avivey updated this revision to Diff 32047.Jun 12 2015, 4:19 AM

avivey retitled this revision from to lose help cursor on blur.

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

avivey added a task: T8501: Cursor stuck in 'help' mode after Ctrl+F.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 12 2015, 4:19 AM

Herald added a subscriber: epriestley. · View Herald Transcript

(I've only tested this on windows chrome/ie for now. It appears that when changing the cursor property on windows, we need to move the mouse a bit for it to take effect).

avivey mentioned this in Z1336: General Chat.Aug 27 2015, 2:31 AM

epriestley accepted this revision.Aug 27 2015, 11:15 AM

epriestley added a reviewer: epriestley.

epriestley added inline comments.