HomePhabricator

Fix possible recursive embeds in Dashboard text panels

Description

Fix possible recursive embeds in Dashboard text panels

Summary:
We currently detect tab panels embedding themselves, but do not detect text panels embedding themselves with {Wxx}.

Detect these self-embedding panels.

I had to add a bit of a hack to pass the parent panel PHIDs to the rule. Generally, I got the Markup API kind of wrong and want to update it, I'll file a followup with details about how I'd like to move forward.

Test Plan:
Created a text panel embedding itself, a tab panel embedding a text panel embedding itself, a tab panel embedding a text panel embedding the tab panel, etc.

Rendered all panels standalone and as {Wxx} from a different context.

Screen Shot 2015-08-26 at 5.39.44 PM.png (231×1 px, 32 KB)

Screen Shot 2015-08-26 at 5.40.50 PM.png (239×1 px, 35 KB)

Screen Shot 2015-08-26 at 5.39.59 PM.png (315×1 px, 46 KB)

Screen Shot 2015-08-26 at 5.41.01 PM.png (343×1 px, 47 KB)

Screen Shot 2015-08-26 at 5.40.39 PM.png (242×1 px, 35 KB)

Reviewers: chad, jbeta

Reviewed By: chad, jbeta

Differential Revision: https://secure.phabricator.com/D13999

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Aug 27 2015, 12:59 AM
Reviewer
chad
Differential Revision
D13999: Fix possible recursive embeds in Dashboard text panels
Parents
rP10966519e2eb: Prevent "commit message magic words" parser from exploding on "reverts aaaa...
Branches
Unknown
Tags
Unknown