Mark some strings for translation
ClosedPublic
Actions

Authored by joshuaspence on Jun 8 2015, 8:20 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPf47e69c01594: Mark some strings for translation

Summary

Add some more phtizations.

Test Plan

Eyeball it.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 6633
Build 6655: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	65 ms	PhabricatorProjectEditorTestCase::testJoinLeaveProject
	63 ms	PhabricatorProjectEditorTestCase::testViewProject
	0 ms	AphrontHTTPSinkTestCase::testHTTPHeaderNames
	0 ms	AphrontHTTPSinkTestCase::testHTTPSinkBasics
	0 ms	AphrontHTTPSinkTestCase::testHTTPSinkResponseSplitting
		View Full Test Results (2 Failed · 74 Passed)

Event Timeline

joshuaspence updated this revision to Diff 31902.Jun 8 2015, 8:20 AM

joshuaspence retitled this revision from to Add some missing translations.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 8 2015, 8:20 AM

Herald added subscribers: epriestley, Korvin, hach-que. · View Herald Transcript

joshuaspence retitled this revision from Add some missing translations to Mark some strings for translation.Jun 8 2015, 8:22 AM

joshuaspence edited edge metadata.

Missed one

epriestley accepted this revision.Jun 8 2015, 8:51 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/audit/editor/PhabricatorAuditEditor.php
612 ↗	(On Diff #31903)	I think this should be untranslated: it's read by client software to thread mail, not human users.
src/applications/macro/editor/PhabricatorMacroEditor.php
158 ↗	(On Diff #31903)	Same reasoning.
src/infrastructure/customfield/field/PhabricatorCustomFieldAttachment.php
24	Errant `}`.
src/infrastructure/testing/PhabricatorTestCase.php
187	Completely nitpicking, but maybe use `%s`, since `$seed` isn't necessarily numeric in the future, even though it is today.

This revision is now accepted and ready to land.Jun 8 2015, 8:51 PM

As requested

I hit this exception whilst running the unit tests, not sure why (although I haven't looked into it yet):

EXCEPTION (PhutilAggregateException): Multiple exceptions were raised during test execution.
    - Execution: PhabricatorApplicationTransactionStructureException: Attempting to apply a transaction (of class "PhabricatorUserTransaction", with type "core:edge") which has not been constructed correctly: Transaction has type "core:edge", but that transaction type is not supported by this editor (PhabricatorUserProfileEditor).
    - Shutdown: Exception: Process exited with an open transaction! The transaction will be implicitly rolled back. Calls to openTransaction() must always be paired with a call to saveTransaction() or killTransaction().
#0 /home/joshua/workspace/github.com/phacility/arcanist/src/unit/engine/PhutilUnitTestEngine.php(65): PhutilTestCase->run()
#1 /home/joshua/workspace/github.com/phacility/arcanist/src/workflow/ArcanistUnitWorkflow.php(186): PhutilUnitTestEngine->run()
#2 /home/joshua/workspace/github.com/phacility/arcanist/src/workflow/ArcanistDiffWorkflow.php(1334): ArcanistUnitWorkflow->run()
#3 /home/joshua/workspace/github.com/phacility/arcanist/src/workflow/ArcanistDiffWorkflow.php(1213): ArcanistDiffWorkflow->runUnit()
#4 /home/joshua/workspace/github.com/phacility/arcanist/src/workflow/ArcanistDiffWorkflow.php(474): ArcanistDiffWorkflow->runLintUnit()
#5 /home/joshua/workspace/github.com/phacility/arcanist/scripts/arcanist.php(382): ArcanistDiffWorkflow->run()
#6 {main}