Add some more phtizations.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rPf47e69c01594: Mark some strings for translation
Eyeball it.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/applications/audit/editor/PhabricatorAuditEditor.php | ||
|---|---|---|
| 612 ↗ | (On Diff #31903) | I think this should be untranslated: it's read by client software to thread mail, not human users. |
| src/applications/macro/editor/PhabricatorMacroEditor.php | ||
| 158 ↗ | (On Diff #31903) | Same reasoning. |
| src/infrastructure/customfield/field/PhabricatorCustomFieldAttachment.php | ||
| 24 | Errant }. | |
| src/infrastructure/testing/PhabricatorTestCase.php | ||
| 187 | Completely nitpicking, but maybe use %s, since $seed isn't necessarily numeric in the future, even though it is today. | |
Comment Actions
I hit this exception whilst running the unit tests, not sure why (although I haven't looked into it yet):
EXCEPTION (PhutilAggregateException): Multiple exceptions were raised during test execution.
- Execution: PhabricatorApplicationTransactionStructureException: Attempting to apply a transaction (of class "PhabricatorUserTransaction", with type "core:edge") which has not been constructed correctly: Transaction has type "core:edge", but that transaction type is not supported by this editor (PhabricatorUserProfileEditor).
- Shutdown: Exception: Process exited with an open transaction! The transaction will be implicitly rolled back. Calls to openTransaction() must always be paired with a call to saveTransaction() or killTransaction().
#0 /home/joshua/workspace/github.com/phacility/arcanist/src/unit/engine/PhutilUnitTestEngine.php(65): PhutilTestCase->run()
#1 /home/joshua/workspace/github.com/phacility/arcanist/src/workflow/ArcanistUnitWorkflow.php(186): PhutilUnitTestEngine->run()
#2 /home/joshua/workspace/github.com/phacility/arcanist/src/workflow/ArcanistDiffWorkflow.php(1334): ArcanistUnitWorkflow->run()
#3 /home/joshua/workspace/github.com/phacility/arcanist/src/workflow/ArcanistDiffWorkflow.php(1213): ArcanistDiffWorkflow->runUnit()
#4 /home/joshua/workspace/github.com/phacility/arcanist/src/workflow/ArcanistDiffWorkflow.php(474): ArcanistDiffWorkflow->runLintUnit()
#5 /home/joshua/workspace/github.com/phacility/arcanist/scripts/arcanist.php(382): ArcanistDiffWorkflow->run()
#6 {main}