Paths

Table of Contentst

Differential D13186

Fix some method visibilities
ClosedPublic
Actions

Authored by joshuaspence on Jun 7 2015, 9:06 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP259b40fc28e3: Fix some method visibilities

Summary

See D13185, the testMethodVisibility() test was not being executed.

Test Plan

arc unit

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6597
Build 6619: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 31870.Jun 7 2015, 9:06 AM

joshuaspence retitled this revision from to Fix some method visibilities.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 7 2015, 9:06 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jun 7 2015, 1:30 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 7 2015, 1:30 PM

Closed by commit rP259b40fc28e3: Fix some method visibilities (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 7 2015, 11:52 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D13201: Fix method visibilities.Jun 8 2015, 8:40 AM

joshuaspence mentioned this in rPaf1b586990a7: Fix method visibilities.Jun 8 2015, 9:18 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

paste/

query/

PhabricatorPasteSearchEngine.php

2 lines

spaces/

view/

PhabricatorSpacesControl.php

2 lines

Diff 31870

View Options

src/applications/paste/query/PhabricatorPasteSearchEngine.php