Fixes T8401. Change withIncludeGhosts() to withExcludeGhosts() and withIncludeUndocumentable() to withExcludeDocumentable(). In particular, this allows querying for atoms by PHID to work as expected.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T8401: Unable to query Diviner atoms by PHID
- Commits
- Restricted Diffusion Commit
rP32f669d56665: Invert include/exclude logic on DivinerAtomQuery
I got confused with double negatives so I might have gotten some of these wrong... I poked around Diviner and re-generated documentation to verify that this is working as expected.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 6549 Build 6571: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Also slightly more modern is withGhosts(), defaulting to null, and accepting true to mean "ghosts only" or false to mean "no ghosts". See PeopleQuery for an example if you want to go that route.