Page MenuHomePhabricator

Allow ghost atoms to be rendered
ClosedPublic

Authored by joshuaspence on Jun 2 2015, 12:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 13, 9:20 AM
Unknown Object (File)
Sat, Aug 13, 9:20 AM
Unknown Object (File)
Sat, Aug 13, 9:20 AM
Unknown Object (File)
Sat, Aug 13, 9:20 AM
Unknown Object (File)
Wed, Aug 10, 9:10 AM
Unknown Object (File)
Wed, Aug 3, 1:55 AM
Unknown Object (File)
Thu, Jul 28, 5:15 AM
Unknown Object (File)
Sun, Jul 24, 7:31 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4558: Make Diviner useful for third-parties
Commits
Restricted Diffusion Commit
rP006a877996aa: Allow ghost atoms to be rendered
Summary

Ref T4558. Allow ghost atoms to be rendered in Diviner. This functionality didn't exist previously, but was hinted at by the TODO comments.

Test Plan

Generated Diviner documentation for rARC and then removed a class (before re-generating the documentation). Navigated to the documentation for the removed class and saw "This atom no longer exists".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Allow ghost documentation to be rendered.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence edited edge metadata.

Further progress

joshuaspence retitled this revision from Allow ghost documentation to be rendered to Allow ghost atoms to be rendered.Jun 3 2015, 1:19 PM
joshuaspence updated this object.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2015, 4:31 PM
src/applications/diviner/storage/DivinerLiveSymbol.php
101–107

Is this the normal way to allow an attachable object to be nullable? It seemed odd to me.

Yeah. Normally the assignment is just $this->thing = $thing;, but the = null is normal.

This revision was automatically updated to reflect the committed changes.