Page MenuHomePhabricator
Differential D13114

Allow ghost atoms to be rendered
ClosedPublic
Actions

Authored by joshuaspence on Jun 2 2015, 12:59 PM.
Tags
None
Referenced Files
F14057116: D13114.diff
Sun, Nov 17, 12:34 AM
F14011375: D13114.id31819.diff
Thu, Oct 31, 11:32 PM
F13993806: D13114.id.diff
Wed, Oct 23, 1:33 AM
F13991370: D13114.id31662.diff
Tue, Oct 22, 10:26 AM
F13983219: D13114.diff
Sun, Oct 20, 4:53 AM
F13978581: D13114.id31713.diff
Oct 18 2024, 11:56 PM
F13977817: D13114.diff
Oct 18 2024, 8:13 PM
Unknown Object (File)
Oct 9 2024, 1:58 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4558: Make Diviner useful for third-parties
Commits
Restricted Diffusion Commit
rP006a877996aa: Allow ghost atoms to be rendered
Summary

Ref T4558. Allow ghost atoms to be rendered in Diviner. This functionality didn't exist previously, but was hinted at by the TODO comments.

Test Plan

Generated Diviner documentation for rARC and then removed a class (before re-generating the documentation). Navigated to the documentation for the removed class and saw "This atom no longer exists".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 31662.Jun 2 2015, 12:59 PM
joshuaspence retitled this revision from to Allow ghost documentation to be rendered.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 2 2015, 12:59 PM
Herald added a subscriber: epriestley. · View Herald Transcript
joshuaspence updated this revision to Diff 31713.Jun 3 2015, 10:42 AM
joshuaspence edited edge metadata.

Further progress

joshuaspence updated this revision to Diff 31724.Jun 3 2015, 1:19 PM

Tidying

joshuaspence retitled this revision from Allow ghost documentation to be rendered to Allow ghost atoms to be rendered.Jun 3 2015, 1:19 PM
joshuaspence updated this object.
joshuaspence added a task: T4558: Make Diviner useful for third-parties.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence updated this object.Jun 3 2015, 1:22 PM
epriestley accepted this revision.Jun 3 2015, 4:31 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2015, 4:31 PM
joshuaspence added inline comments.Jun 3 2015, 10:04 PM
src/applications/diviner/storage/DivinerLiveSymbol.php
101–107

Is this the normal way to allow an attachable object to be nullable? It seemed odd to me.

epriestley added a comment.Jun 3 2015, 10:06 PM

Yeah. Normally the assignment is just $this->thing = $thing;, but the = null is normal.

joshuaspence mentioned this in D13157: Invert include/exclude logic on DivinerAtomQuery.Jun 4 2015, 9:07 PM
joshuaspence updated this revision to Diff 31819.Jun 5 2015, 8:08 AM
joshuaspence edited edge metadata.

Rebase

Herald added a subscriber: Korvin. · View Herald TranscriptJun 5 2015, 8:08 AM
Closed by commit rP006a877996aa: Allow ghost atoms to be rendered (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 5 2015, 8:08 AM
This revision was automatically updated to reflect the committed changes.
cburroughs mentioned this in T9171: old maniphest_custom docs hang around, posisble confusing googlers.Aug 13 2015, 7:26 PM

Revision Contents
Changeset List

PathSize
src/
applications/
diviner/
controller/
110 lines
query/
37 lines
storage/
12 lines

Diff 31820

View Options

src/applications/diviner/controller/DivinerAtomController.php

Loading...
View Options

src/applications/diviner/query/DivinerAtomQuery.php

Loading...
View Options

src/applications/diviner/storage/DivinerLiveSymbol.php

Loading...
Phabricator · Built by Phacility