Invert include/exclude logic on DivinerAtomQuery
ClosedPublic
Actions

Authored by joshuaspence on Jun 4 2015, 9:04 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8401: Unable to query Diviner atoms by PHID

Commits

Restricted Diffusion Commit
rP32f669d56665: Invert include/exclude logic on DivinerAtomQuery

Summary

Fixes T8401. Change withIncludeGhosts() to withExcludeGhosts() and withIncludeUndocumentable() to withExcludeDocumentable(). In particular, this allows querying for atoms by PHID to work as expected.

Test Plan

I got confused with double negatives so I might have gotten some of these wrong... I poked around Diviner and re-generated documentation to verify that this is working as expected.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 31795.Jun 4 2015, 9:04 PM

joshuaspence retitled this revision from to Invert include/exclude logic on DivinerAtomQuery.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T8401: Unable to query Diviner atoms by PHID.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 4 2015, 9:04 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

I intentionally didn't change the following:

DivinerAtomPHIDType
DivinerAtomSearchEngine

src/applications/diviner/controller/DivinerAtomController.php
50–51	This will be changed when I land D13114.

joshuaspence added a child revision: D13090: Integrate Diviner with global search.Jun 4 2015, 9:08 PM

Also slightly more modern is withGhosts(), defaulting to null, and accepting true to mean "ghosts only" or false to mean "no ghosts". See PeopleQuery for an example if you want to go that route.

This revision is now accepted and ready to land.Jun 4 2015, 9:08 PM