Page MenuHomePhabricator
Differential D13113

Revert "Don't consider strings with variables to be static"
ClosedPublic
Actions

Authored by joshuaspence on Jun 2 2015, 12:06 PM.
Tags
None
Referenced Files
F15517002: D13113.id31655.diff
Fri, Apr 18, 11:10 PM
F15507187: D13113.diff
Tue, Apr 15, 5:09 PM
F15471217: D13113.id31654.diff
Sat, Apr 5, 4:09 AM
F15446960: D13113.id31655.diff
Thu, Mar 27, 9:05 PM
F15444152: D13113.id31654.diff
Thu, Mar 27, 8:08 AM
F15441093: D13113.id.diff
Wed, Mar 26, 4:20 PM
F15435016: D13113.diff
Tue, Mar 25, 6:27 AM
F15429666: D13113.id31654.diff
Mon, Mar 24, 3:31 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8379: ArcanistFormattedStringXHPASTLinterRule fails
Commits
rPHU9a21607bf50b: Revert "Don't consider strings with variables to be static"
Summary

Fixes T8379. This is causing some issues with linter rules so maybe this should just wait until T8049.

This reverts commit a9e581f6488fd7db83d4c02edee64db9b1cd3ef9.

Test Plan

N/A

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6450
Build 6472: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 31654.Jun 2 2015, 12:06 PM
joshuaspence retitled this revision from to Revert "Don't consider strings with variables to be static".
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T8379: ArcanistFormattedStringXHPASTLinterRule fails.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 2 2015, 12:06 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jun 2 2015, 12:06 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 2 2015, 12:06 PM
Closed by commit rPHU9a21607bf50b: Revert "Don't consider strings with variables to be static" (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 2 2015, 12:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
xhpast/
api/
24 lines
__tests__/
3 lines

Diff 31654

View Options

src/parser/xhpast/api/XHPASTNode.php

Loading...
View Options

src/parser/xhpast/api/__tests__/XHPASTTreeTestCase.php

Loading...
Phabricator · Built by Phacility