Differential D13113

Revert "Don't consider strings with variables to be static"
ClosedPublic
Actions

Authored by joshuaspence on Jun 2 2015, 12:06 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8379: ArcanistFormattedStringXHPASTLinterRule fails

Commits

rPHU9a21607bf50b: Revert "Don't consider strings with variables to be static"

Summary

Fixes T8379. This is causing some issues with linter rules so maybe this should just wait until T8049.

This reverts commit a9e581f6488fd7db83d4c02edee64db9b1cd3ef9.

Test Plan

N/A

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 31654.Jun 2 2015, 12:06 PM

joshuaspence retitled this revision from to Revert "Don't consider strings with variables to be static".

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T8379: ArcanistFormattedStringXHPASTLinterRule fails.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 2 2015, 12:06 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jun 2 2015, 12:06 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 2 2015, 12:06 PM

Closed by commit rPHU9a21607bf50b: Revert "Don't consider strings with variables to be static" (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 2 2015, 12:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

api/

XHPASTNode.php

20 lines

__tests__/

XHPASTTreeTestCase.php

3 lines

Diff 31655

View Options

src/parser/xhpast/api/XHPASTNode.php

View Options

src/parser/xhpast/api/tests/XHPASTTreeTestCase.php

Revert "Don't consider strings with variables to be static"ClosedPublicActions