Page MenuHomePhabricator
Differential D13006

Improve UX for Diffusion mail fields
ClosedPublic
Actions

Authored by epriestley on May 25 2015, 1:23 PM.
Tags
None
Referenced Files
F14065169: D13006.diff
Tue, Nov 19, 3:27 AM
F14057279: D13006.id31365.diff
Sun, Nov 17, 2:01 AM
F14036367: D13006.diff
Sun, Nov 10, 9:57 AM
F14020600: D13006.diff
Wed, Nov 6, 12:55 AM
F14002328: D13006.id31365.diff
Fri, Oct 25, 5:57 PM
F13990571: D13006.id31364.diff
Tue, Oct 22, 4:34 AM
F13973723: D13006.id.diff
Oct 18 2024, 2:15 AM
F13957976: D13006.diff
Oct 14 2024, 12:16 PM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
fabe
Commits
Restricted Diffusion Commit
rPea131bb2efb9: Improve UX for Diffusion mail fields
Summary
  • Give the fields names and descriptions.
  • When new, default-disabled fields are added, disable them by default even if there's already a config.
  • Be a bit less hacky about $faux_spec.
Test Plan

Screen Shot 2015-05-25 at 6.21.38 AM.png (322×990 px, 45 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31364.May 25 2015, 1:23 PM
epriestley retitled this revision from to Improve UX for Diffusion mail fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, fabe.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 25 2015, 1:23 PM
fabe accepted this revision.May 25 2015, 2:09 PM
fabe edited edge metadata.

Nice :)

This revision is now accepted and ready to land.May 25 2015, 2:09 PM
Closed by commit rPea131bb2efb9: Improve UX for Diffusion mail fields (authored by epriestley, committed by epriestley). · Explain WhyMay 25 2015, 2:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31365

View Options

src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php

Loading...
View Options

src/applications/repository/customfield/PhabricatorCommitBranchesField.php

Loading...
View Options

src/applications/repository/customfield/PhabricatorCommitMergedCommitsField.php

Loading...
View Options

src/applications/repository/customfield/PhabricatorCommitRepositoryField.php

Loading...
View Options

src/applications/repository/customfield/PhabricatorCommitTagsField.php

Loading...
View Options

src/infrastructure/customfield/config/PhabricatorCustomFieldConfigOptionType.php

Loading...
View Options

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...
Phabricator · Built by Phacility