Page MenuHomePhabricator
Differential D13006

Improve UX for Diffusion mail fields
ClosedPublic
Actions

Authored by epriestley on May 25 2015, 1:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 2:34 AM
Unknown Object (File)
Mon, Apr 29, 2:07 PM
Unknown Object (File)
Wed, Apr 24, 10:11 PM
Unknown Object (File)
Fri, Apr 12, 8:17 AM
Unknown Object (File)
Thu, Apr 11, 7:31 AM
Unknown Object (File)
Fri, Apr 5, 1:25 AM
Unknown Object (File)
Mar 28 2024, 10:29 AM
Unknown Object (File)
Mar 19 2024, 9:10 PM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
fabe
Commits
Restricted Diffusion Commit
rPea131bb2efb9: Improve UX for Diffusion mail fields
Summary
  • Give the fields names and descriptions.
  • When new, default-disabled fields are added, disable them by default even if there's already a config.
  • Be a bit less hacky about $faux_spec.
Test Plan

Screen Shot 2015-05-25 at 6.21.38 AM.png (322×990 px, 45 KB)

Diff Detail

Repository
rP Phabricator
Branch
dcustom
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6266
Build 6288: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31364.May 25 2015, 1:23 PM
epriestley retitled this revision from to Improve UX for Diffusion mail fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, fabe.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 25 2015, 1:23 PM
fabe accepted this revision.May 25 2015, 2:09 PM
fabe edited edge metadata.

Nice :)

This revision is now accepted and ready to land.May 25 2015, 2:09 PM
Closed by commit rPea131bb2efb9: Improve UX for Diffusion mail fields (authored by epriestley, committed by epriestley). · Explain WhyMay 25 2015, 2:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31364

View Options

src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php

Loading...
View Options

src/applications/repository/customfield/PhabricatorCommitBranchesField.php

Loading...
View Options

src/applications/repository/customfield/PhabricatorCommitMergedCommitsField.php

Loading...
View Options

src/applications/repository/customfield/PhabricatorCommitRepositoryField.php

Loading...
View Options

src/applications/repository/customfield/PhabricatorCommitTagsField.php

Loading...
View Options

src/infrastructure/customfield/config/PhabricatorCustomFieldConfigOptionType.php

Loading...
View Options

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...
Phabricator · Built by Phacility