Paths

Table of Contentst

Differential D12976

Change visibility of some linter methods
ClosedPublic
Actions

Authored by joshuaspence on May 22 2015, 7:47 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC9b7c6786cdc9: Change visibility of some linter methods

Summary

Change the visibility of the raiseLintAtSomething methods, mainly to allow linter rules to raise linter messages (see D10541).

Test Plan

arc unit

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6210
Build 6231: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 31270.May 22 2015, 7:47 AM

joshuaspence retitled this revision from to Change visibility of some linter methods.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 22 2015, 7:47 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.May 22 2015, 2:04 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 22 2015, 2:04 PM

Closed by commit rARC9b7c6786cdc9: Change visibility of some linter methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 23 2015, 9:45 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence added a child revision: D10541: Split the `ArcanistXHPASTLinter` into modular rules.Jun 1 2015, 5:44 AM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistBaseXHPASTLinter.php

4 lines

ArcanistLinter.php

6 lines

Diff 31270

View Options

src/lint/linter/ArcanistBaseXHPASTLinter.php