Remove "commit hook mode" workarounds for ArcanistXHPASTLinter
ClosedPublic
Actions

Authored by joshuaspence on May 20 2015, 9:06 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7674: Remove support for arc commit hooks

Commits

rARCe72a43a99247: Remove "commit hook mode" workarounds for ArcanistXHPASTLinter

Summary

Ref T7674. ArcanistXHPASTLinter has some workarounds for running in "commit hook" mode (which has since been removed). This linter should always have a working copy.

Test Plan

arc unit

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 31204.May 20 2015, 9:06 PM

joshuaspence retitled this revision from to Remove "commit hook mode" workarounds for ArcanistXHPASTLinter.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T7674: Remove support for arc commit hooks.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 20 2015, 9:06 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence added a child revision: D10541: Split the `ArcanistXHPASTLinter` into modular rules.May 20 2015, 9:07 PM

epriestley accepted this revision.May 20 2015, 9:13 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 20 2015, 9:13 PM

Closed by commit rARCe72a43a99247: Remove "commit hook mode" workarounds for ArcanistXHPASTLinter (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 21 2015, 5:08 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

35 lines

Diff 31220

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Remove "commit hook mode" workarounds for ArcanistXHPASTLinterClosedPublicActions