Page MenuHomePhabricator
Differential D12964

Return empty array as a default value for repository symbol languages
ClosedPublic
Actions

Authored by epriestley on May 21 2015, 2:30 PM.
Tags
None
Referenced Files
F14021965: D12964.diff
Wed, Nov 6, 2:11 PM
F14021702: D12964.id.diff
Wed, Nov 6, 11:33 AM
F14018828: D12964.diff
Tue, Nov 5, 8:03 PM
F13967558: D12964.id31240.diff
Wed, Oct 16, 2:28 PM
Unknown Object (File)
Sep 19 2024, 12:14 AM
Unknown Object (File)
Sep 19 2024, 12:10 AM
Unknown Object (File)
Sep 19 2024, 12:10 AM
Unknown Object (File)
Sep 16 2024, 1:39 PM
View All Files
Subscribers
epriestley
Tokens
"Pterodactyl" token, awarded by avivey.

Details

Reviewers
joshuaspence
btrahan
avivey
Maniphest Tasks
T8283: Error thrown when opening a file in Diffusion's file browser
Commits
Restricted Diffusion Commit
rPa50de8958efb: Return empty array as a default value for repository symbol languages
Summary

Fixes T8283. The code in FileController assumes this value is an array.

Test Plan

Loaded any file in Diffusion in unconfigured repository, no more warning.

Diff Detail

Repository
rP Phabricator
Branch
sourcedefault
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6184
Build 6205: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31233.May 21 2015, 2:30 PM
epriestley retitled this revision from to Return empty array as a default value for repository symbol languages.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: avivey, joshuaspence, btrahan.
epriestley added a task: T8283: Error thrown when opening a file in Diffusion's file browser.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 21 2015, 2:30 PM
btrahan accepted this revision.May 21 2015, 4:27 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 21 2015, 4:27 PM
Closed by commit rPa50de8958efb: Return empty array as a default value for repository symbol languages (authored by epriestley, committed by epriestley). · Explain WhyMay 21 2015, 4:28 PM
This revision was automatically updated to reflect the committed changes.
avivey awarded a token.May 21 2015, 5:08 PM

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
storage/
4 lines

Diff 31233

View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility