Paths

Table of Contentst

Raise a setup issue for misconfigured Elasticsearch
ClosedPublic
Actions

Authored by epriestley on May 20 2015, 1:23 PM.

Details

Reviewers

joshuaspence
btrahan

Maniphest Tasks

T8274: Misconfigured Elasticsearch can fatal the setup issue process

Commits

Restricted Diffusion Commit
rPf5a9d1f8d47b: Raise a setup issue for misconfigured Elasticsearch

Summary

Fixes T8274. That report is very light on details, but I think the issue is that their Elasticsearch is misconfigured and the new setup warning dies a little too hard if the server is just completely dead.

Test Plan

Set search.elastic.host to an invalid server, got a similar-looking exception (?), applied patch, got a setup warning instead.

Diff Detail

Repository

rP Phabricator

Branch

esearch1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6152
Build 6173: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31185.May 20 2015, 1:23 PM

epriestley retitled this revision from to Raise a setup issue for misconfigured Elasticsearch.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, joshuaspence.

epriestley added a task: T8274: Misconfigured Elasticsearch can fatal the setup issue process.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 20 2015, 1:23 PM

epriestley mentioned this in T8274: Misconfigured Elasticsearch can fatal the setup issue process.May 20 2015, 2:38 PM

btrahan accepted this revision.May 20 2015, 8:47 PM

btrahan edited edge metadata.

btrahan added inline comments.

src/applications/config/check/PhabricatorElasticSearchSetupCheck.php
19–21	these methods existed already? cool!

This revision is now accepted and ready to land.May 20 2015, 8:47 PM

joshuaspence accepted this revision.May 20 2015, 8:52 PM

joshuaspence edited edge metadata.

Closed by commit rPf5a9d1f8d47b: Raise a setup issue for misconfigured Elasticsearch (authored by epriestley, committed by epriestley). · Explain WhyMay 20 2015, 9:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorElasticSearchSetupCheck.php

91 lines

Diff 31185

View Options

src/applications/config/check/PhabricatorElasticSearchSetupCheck.php

Raise a setup issue for misconfigured ElasticsearchClosedPublicActions