Page MenuHomePhabricator
Differential D12663

Add repository parameter to `diffusion.findsymbols` method
ClosedPublic
Actions

Authored by joshuaspence on May 3 2015, 3:45 AM.
Tags
None
Referenced Files
F14836541: D12663.diff
Fri, Jan 31, 3:00 AM
F14834555: D12663.id.diff
Thu, Jan 30, 3:59 PM
Unknown Object (File)
Mon, Jan 27, 7:57 PM
Unknown Object (File)
Fri, Jan 24, 3:49 AM
Unknown Object (File)
Fri, Jan 24, 3:49 AM
Unknown Object (File)
Fri, Jan 24, 3:49 AM
Unknown Object (File)
Fri, Jan 24, 3:49 AM
Unknown Object (File)
Fri, Jan 24, 3:49 AM
View All Files
Subscribers
avivey
eadler
epriestley
Korvin

Details

Reviewers
epriestley
eadler
avivey
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7977: Associate Symbols with Repositories directly (Instead of arc projects)
Commits
Restricted Diffusion Commit
rP2cc898a63f00: Add repository parameter to `diffusion.findsymbols` method
Summary

Ref T7977. Add a repository parameter to the diffusion.findsymbols Conduit method to allow restricting search results to the specified repository.

Test Plan

Queried the Conduit endpoint.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 30423.May 3 2015, 3:45 AM
joshuaspence retitled this revision from to Add repository parameter to `diffusion.findsymbols` method.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7977: Associate Symbols with Repositories directly (Instead of arc projects).
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 3 2015, 3:45 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
avivey accepted this revision.May 3 2015, 3:58 AM
avivey added a reviewer: avivey.
avivey added a subscriber: avivey.

lgtm.

src/applications/diffusion/conduit/DiffusionFindSymbolsConduitAPIMethod.php
73

maybe PHID? or both? Do we have a convention?

eadler added a subscriber: eadler.May 3 2015, 5:05 AM
epriestley accepted this revision.May 3 2015, 1:10 PM
epriestley edited edge metadata.

Yeah, I think preferable/standard is to call the parameter repositoryPHID and return repositoryPHID with the PHID. Rest of it looks good.

This revision is now accepted and ready to land.May 3 2015, 1:10 PM
joshuaspence updated this revision to Diff 30520.May 4 2015, 9:39 PM
joshuaspence edited edge metadata.

Use PHID

eadler accepted this revision.May 4 2015, 9:53 PM
eadler added a reviewer: eadler.
Closed by commit rP2cc898a63f00: Add repository parameter to `diffusion.findsymbols` method (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 4 2015, 10:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
conduit/
30 lines

Diff 30523

View Options

src/applications/diffusion/conduit/DiffusionFindSymbolsConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility