Page MenuHomePhabricator

Fix an issue where "Browse > Select" did not work for dynamic tokenizers
ClosedPublic

Authored by epriestley on Apr 23 2015, 1:16 PM.
Tags
None
Referenced Files
F15337812: D12529.id30076.diff
Sun, Mar 9, 7:49 AM
Unknown Object (File)
Thu, Feb 20, 10:14 AM
Unknown Object (File)
Wed, Feb 19, 4:45 PM
Unknown Object (File)
Feb 9 2025, 6:23 PM
Unknown Object (File)
Feb 8 2025, 12:04 PM
Unknown Object (File)
Feb 8 2025, 3:54 AM
Unknown Object (File)
Feb 8 2025, 3:54 AM
Unknown Object (File)
Feb 8 2025, 3:54 AM
Subscribers

Details

Summary

Ref T4100. In Herald, using the browse dialog to select a result didn't work because we'd add the token with no name value. Other things would render it elsewhere, but it would eventaully be discarded.

Instead, add it with a name value.

Test Plan

Edited a Herald rule and used Browse > Select to add a token. Saved rule. Saw token persist.

Diff Detail

Repository
rP Phabricator
Branch
search7
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5471
Build 5489: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix an issue where "Browse > Select" did not work for dynamic tokenizers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 23 2015, 5:30 PM
This revision was automatically updated to reflect the committed changes.