Page MenuHomePhabricator

Fix an issue where "Browse > Select" did not work for dynamic tokenizers
ClosedPublic

Authored by epriestley on Apr 23 2015, 1:16 PM.
Tags
None
Referenced Files
F13048976: D12529.diff
Fri, Apr 19, 12:01 AM
Unknown Object (File)
Sun, Apr 14, 5:37 PM
Unknown Object (File)
Thu, Apr 11, 9:01 AM
Unknown Object (File)
Fri, Apr 5, 11:32 PM
Unknown Object (File)
Feb 12 2024, 11:53 PM
Unknown Object (File)
Feb 12 2024, 11:49 AM
Unknown Object (File)
Feb 3 2024, 3:28 AM
Unknown Object (File)
Feb 1 2024, 1:47 PM
Subscribers

Details

Summary

Ref T4100. In Herald, using the browse dialog to select a result didn't work because we'd add the token with no name value. Other things would render it elsewhere, but it would eventaully be discarded.

Instead, add it with a name value.

Test Plan

Edited a Herald rule and used Browse > Select to add a token. Saved rule. Saw token persist.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix an issue where "Browse > Select" did not work for dynamic tokenizers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 23 2015, 5:30 PM
This revision was automatically updated to reflect the committed changes.