Page MenuHomePhabricator

Fix an issue where "Browse > Select" did not work for dynamic tokenizers
ClosedPublic

Authored by epriestley on Apr 23 2015, 1:16 PM.
Tags
None
Referenced Files
F15507204: D12529.diff
Tue, Apr 15, 5:25 PM
F15504852: D12529.diff
Mon, Apr 14, 9:37 PM
F15464702: D12529.id30087.diff
Wed, Apr 2, 12:33 PM
F15461480: D12529.id30076.diff
Tue, Apr 1, 8:36 AM
F15461031: D12529.id.diff
Tue, Apr 1, 4:32 AM
F15460318: D12529.diff
Mon, Mar 31, 9:57 PM
F15419647: D12529.id30076.diff
Fri, Mar 21, 7:43 AM
F15337812: D12529.id30076.diff
Mar 9 2025, 7:49 AM
Subscribers

Details

Summary

Ref T4100. In Herald, using the browse dialog to select a result didn't work because we'd add the token with no name value. Other things would render it elsewhere, but it would eventaully be discarded.

Instead, add it with a name value.

Test Plan

Edited a Herald rule and used Browse > Select to add a token. Saved rule. Saw token persist.

Diff Detail

Repository
rP Phabricator
Branch
search7
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5471
Build 5489: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix an issue where "Browse > Select" did not work for dynamic tokenizers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 23 2015, 5:30 PM
This revision was automatically updated to reflect the committed changes.