Page MenuHomePhabricator

Improve performance of LINT_UNNECESSARY_SEMICOLON
ClosedPublic

Authored by joshuaspence on Apr 23 2015, 1:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 2:13 AM
Unknown Object (File)
Thu, Dec 12, 3:12 PM
Unknown Object (File)
Fri, Dec 6, 5:25 AM
Unknown Object (File)
Thu, Dec 5, 6:28 PM
Unknown Object (File)
Mon, Dec 2, 3:05 AM
Unknown Object (File)
Mon, Dec 2, 3:05 AM
Unknown Object (File)
Mon, Dec 2, 3:04 AM
Unknown Object (File)
Mon, Dec 2, 3:04 AM
Subscribers

Details

Summary

Ref T7892. Improve the performance of ArcanistXHPASTLinter::LINT_UNNECESSARY_SEMICOLON.

Test Plan

Wiped 6 seconds off the total time to lint rARC.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 5463
Build 5481: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
1,248 msArcanistPuppetLintLinterTestCase::testLinter
871 msArcanistCSSLintLinterTestCase::testLinter
194 msArcanistCSSLintLinterTestCase::testVersion
132 msArcanistChmodLinterTestCase::testLinter
232 msArcanistClosureLinterTestCase::testLinter
View Full Test Results (1 Failed · 48 Passed · 4 Skipped)

Event Timeline

joshuaspence retitled this revision from to Improve performance of LINT_UNNECESSARY_SEMICOLON.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 23 2015, 1:40 AM
joshuaspence edited edge metadata.

Fix failing test cases

This revision was automatically updated to reflect the committed changes.