Page MenuHomePhabricator

D12519.id.diff
No OneTemporary

D12519.id.diff

diff --git a/src/lint/linter/ArcanistXHPASTLinter.php b/src/lint/linter/ArcanistXHPASTLinter.php
--- a/src/lint/linter/ArcanistXHPASTLinter.php
+++ b/src/lint/linter/ArcanistXHPASTLinter.php
@@ -3490,7 +3490,13 @@
continue;
}
- if ($statement->getSemanticString() == ';') {
+ if (count($statement->getChildren()) > 1) {
+ continue;
+ } else if ($statement->getChildByIndex(0)->getTypeName() != 'n_EMPTY') {
+ continue;
+ }
+
+ if ($statement->getConcreteString() == ';') {
$this->raiseLintAtNode(
$statement,
self::LINT_UNNECESSARY_SEMICOLON,

File Metadata

Mime Type
text/plain
Expires
Mon, Jul 28, 1:51 AM (1 d, 23 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
8580312
Default Alt Text
D12519.id.diff (632 B)

Event Timeline