Paths

Table of Contentst

Differential D12519

Improve performance of LINT_UNNECESSARY_SEMICOLON
ClosedPublic
Actions

Authored by joshuaspence on Apr 23 2015, 1:38 AM.

Tags

None

Referenced Files

	F17844242: D12519.id.diff
	Sun, Jul 27, 1:51 AM

	F17801658: D12519.diff
	Fri, Jul 25, 8:04 AM

	F17764634: D12519.diff
	Wed, Jul 23, 12:52 AM

	Unknown Object (File)
	Jun 19 2025, 6:57 AM

	Unknown Object (File)
	May 19 2025, 7:16 AM

	Unknown Object (File)
	Apr 23 2025, 1:54 AM

	Unknown Object (File)
	Apr 22 2025, 11:17 PM

	Unknown Object (File)
	Apr 20 2025, 4:24 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7892: Investigate lint performance issues

Commits

rARC9ddf37b9ee3e: Improve performance of LINT_UNNECESSARY_SEMICOLON

Summary

Ref T7892. Improve the performance of ArcanistXHPASTLinter::LINT_UNNECESSARY_SEMICOLON.

Test Plan

Wiped 6 seconds off the total time to lint rARC.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 5457
Build 5475: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	1,063 ms	ArcanistPuppetLintLinterTestCase::testLinter
	12,857 ms	ArcanistXHPASTLinterTestCase::testLinter
	775 ms	ArcanistCSSLintLinterTestCase::testLinter
	130 ms	ArcanistCSSLintLinterTestCase::testVersion
	135 ms	ArcanistChmodLinterTestCase::testLinter
		View Full Test Results (2 Failed · 47 Passed · 4 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 30058.Apr 23 2015, 1:38 AM

joshuaspence retitled this revision from to Improve performance of LINT_UNNECESSARY_SEMICOLON.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T7892: Investigate lint performance issues.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 23 2015, 1:38 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 23 2015, 1:40 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 23 2015, 1:40 AM

Fix failing test cases

Closed by commit rARC9ddf37b9ee3e: Improve performance of LINT_UNNECESSARY_SEMICOLON (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 23 2015, 10:19 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

6 lines

Diff 30058

src/lint/linter/ArcanistXHPASTLinter.php

Loading...