Move ported inlines which appear on nonvisible lines backward so they show up
ClosedPublic
Actions

Authored by epriestley on Apr 21 2015, 2:01 PM.

Details

Reviewers

Maniphest Tasks

T7447: Bring inline comments forward across revision updates
T7870: List of cases where ghost comments end up somewhere confusing or unexpected

Commits

Restricted Diffusion Commit
rP84f62bdf9a79: Move ported inlines which appear on nonvisible lines backward so they show up

Summary

Ref T7447. Ref T7870. See T7870 for a detailed description of this issue.

NOTE: Replying to these inlines from the UI still does the wrong thing, because we use the database line number, not the UI line number.

Test Plan

Before:

After:

Screen_Shot_2015-04-21_at_6.54.57_AM.png (754×817 px, 78 KB)

Diff Detail

Repository

rP Phabricator

Branch

ghost6

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/differential/parser/DifferentialChangesetParser.php:958	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 5418
Build 5436: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29986.Apr 21 2015, 2:01 PM

epriestley retitled this revision from to Move ported inlines which appear on nonvisible lines backward so they show up.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T7870: List of cases where ghost comments end up somewhere confusing or unexpected, T7447: Bring inline comments forward across revision updates.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 21 2015, 2:01 PM

epriestley mentioned this in T7870: List of cases where ghost comments end up somewhere confusing or unexpected.Apr 21 2015, 2:04 PM

btrahan accepted this revision.Apr 21 2015, 5:34 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 21 2015, 5:34 PM

Closed by commit rP84f62bdf9a79: Move ported inlines which appear on nonvisible lines backward so they show up (authored by epriestley, committed by epriestley). · Explain WhyApr 21 2015, 6:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

parser/

DifferentialChangesetParser.php

85 lines

Diff 29986

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

Move ported inlines which appear on nonvisible lines backward so they show upClosedPublicActions