Page MenuHomePhabricator
Differential D12462

Make "user's projects" a logical datasource and add viewerprojects()
ClosedPublic
Actions

Authored by epriestley on Apr 18 2015, 6:17 PM.
Tags
None
Referenced Files
F13043113: D12462.diff
Wed, Apr 17, 2:14 PM
F13042894: D12462.id29910.diff
Wed, Apr 17, 1:08 PM
Unknown Object (File)
Sun, Apr 14, 3:27 PM
Unknown Object (File)
Wed, Apr 10, 7:49 PM
Unknown Object (File)
Wed, Apr 3, 1:02 AM
Unknown Object (File)
Mar 5 2024, 1:15 AM
Unknown Object (File)
Feb 9 2024, 3:59 PM
Unknown Object (File)
Feb 6 2024, 5:38 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4100: Support query parameterization in typeaheads
T5595: Allow all applications to filter results by project
Commits
Restricted Diffusion Commit
rPf331463d5072: Make "user's projects" a logical datasource and add viewerprojects()
Summary

Ref T4100. Ref T5595. This converts projects(user) into a logical datasource.

Also adds a viewerprojects() logical datasource.

Test Plan

Screen_Shot_2015-04-18_at_11.15.47_AM.png (442×619 px, 51 KB)

Diff Detail

Repository
rP Phabricator
Branch
logic9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5375
Build 5393: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29910.Apr 18 2015, 6:17 PM
epriestley retitled this revision from to Make "user's projects" a logical datasource and add viewerprojects().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T5595: Allow all applications to filter results by project, T4100: Support query parameterization in typeaheads.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 18 2015, 6:17 PM
btrahan accepted this revision.Apr 20 2015, 4:44 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2015, 4:44 PM
Closed by commit rPf331463d5072: Make "user's projects" a logical datasource and add viewerprojects() (authored by epriestley, committed by epriestley). · Explain WhyApr 20 2015, 5:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
10 lines
applications/
people/
typeahead/
project/
typeahead/
PhabricatorProjectLogicalDatasource.php
PhabricatorProjectLogicDatasource.php
4 lines
80 lines
project/
typeahead/
people/
typeahead/
PhabricatorProjectLogicalUserDatasource.php
PhabricatorUserProjectsDatasource.php
25 lines

Diff 29910

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/people/typeahead/PhabricatorUserProjectsDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectLogicDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectLogicalDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectLogicalUserDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectLogicalViewerDatasource.php

Loading...
Phabricator · Built by Phacility