Page MenuHomePhabricator

Require TokenizerControl to always have a datasource
ClosedPublic

Authored by epriestley on Apr 18 2015, 3:43 PM.
Tags
None
Referenced Files
F14727208: D12456.id29899.diff
Sat, Jan 18, 4:14 AM
Unknown Object (File)
Tue, Jan 7, 8:59 AM
Unknown Object (File)
Dec 11 2024, 4:58 AM
Unknown Object (File)
Dec 10 2024, 9:29 AM
Unknown Object (File)
Dec 9 2024, 4:08 AM
Unknown Object (File)
Nov 26 2024, 10:11 PM
Unknown Object (File)
Nov 21 2024, 9:54 PM
Unknown Object (File)
Nov 18 2024, 8:40 AM
Subscribers

Details

Summary

Ref T4100. I can simplify the logic a bit here by moving some rendering into the datasources, but a few TokenizerControls currently don't have datasources.

Require datasources and always provide datasources.

Test Plan
  • Used previously-datasourceless controls (e.g., "Add Reviewers").
  • Used normal controls.
  • Manually verified that no other controls are missing datasources.

Diff Detail

Repository
rP Phabricator
Branch
logic4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5366
Build 5384: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Require TokenizerControl to always have a datasource.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2015, 4:23 PM
This revision was automatically updated to reflect the committed changes.