Page MenuHomePhabricator
Differential D12456

Require TokenizerControl to always have a datasource
ClosedPublic
Actions

Authored by epriestley on Apr 18 2015, 3:43 PM.
Tags
None
Referenced Files
F19511308: D12456.id29899.diff
Mon, Jan 12, 12:40 AM
F19095690: D12456.diff
Dec 4 2025, 5:51 AM
F19036820: D12456.diff
Nov 25 2025, 8:45 PM
F18876756: D12456.diff
Nov 6 2025, 3:13 AM
F18765250: D12456.id.diff
Oct 7 2025, 10:24 AM
F18737886: D12456.id29899.diff
Oct 1 2025, 1:10 PM
F18697826: D12456.id29952.diff
Sep 27 2025, 10:10 AM
F18680079: D12456.id29899.diff
Sep 26 2025, 2:07 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4100: Support query parameterization in typeaheads
Commits
Restricted Diffusion Commit
rPa11dab59b0d5: Require TokenizerControl to always have a datasource
Summary

Ref T4100. I can simplify the logic a bit here by moving some rendering into the datasources, but a few TokenizerControls currently don't have datasources.

Require datasources and always provide datasources.

Test Plan
  • Used previously-datasourceless controls (e.g., "Add Reviewers").
  • Used normal controls.
  • Manually verified that no other controls are missing datasources.

Diff Detail

Repository
rP Phabricator
Branch
logic4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5366
Build 5384: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29899.Apr 18 2015, 3:43 PM
epriestley retitled this revision from to Require TokenizerControl to always have a datasource.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4100: Support query parameterization in typeaheads.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 18 2015, 3:43 PM
btrahan accepted this revision.Apr 20 2015, 4:23 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2015, 4:23 PM
Closed by commit rPa11dab59b0d5: Require TokenizerControl to always have a datasource (authored by epriestley, committed by epriestley). · Explain WhyApr 20 2015, 5:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
view/
12 lines
diffusion/
controller/
12 lines
maniphest/
controller/
17 lines
view/
form/
control/
42 lines

Diff 29899

View Options

src/applications/differential/view/DifferentialAddCommentView.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/view/form/control/AphrontFormTokenizerControl.php

Loading...
Phabricator · Built by Phacility