Page MenuHomePhabricator

Require TokenizerControl to always have a datasource
ClosedPublic

Authored by epriestley on Apr 18 2015, 3:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 12:51 AM
Unknown Object (File)
Sun, Mar 24, 12:30 AM
Unknown Object (File)
Sat, Mar 23, 11:29 AM
Unknown Object (File)
Feb 14 2024, 9:48 AM
Unknown Object (File)
Feb 14 2024, 9:48 AM
Unknown Object (File)
Feb 14 2024, 5:40 AM
Unknown Object (File)
Feb 7 2024, 4:48 PM
Unknown Object (File)
Feb 3 2024, 3:16 AM
Subscribers

Details

Summary

Ref T4100. I can simplify the logic a bit here by moving some rendering into the datasources, but a few TokenizerControls currently don't have datasources.

Require datasources and always provide datasources.

Test Plan
  • Used previously-datasourceless controls (e.g., "Add Reviewers").
  • Used normal controls.
  • Manually verified that no other controls are missing datasources.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Require TokenizerControl to always have a datasource.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2015, 4:23 PM
This revision was automatically updated to reflect the committed changes.