Differential D12405

Conpherence - turn on mentions interface for Conpherence rooms / messages
ClosedPublic
Actions

Authored by btrahan on Apr 13 2015, 11:32 PM.

Tags

None

Referenced Files

	F13180100: D12405.diff
	Wed, May 8, 10:18 PM

	F13179575: D12405.diff
	Wed, May 8, 9:17 PM

	Unknown Object (File)
	Sat, May 4, 6:52 PM

	Unknown Object (File)
	Thu, May 2, 2:28 AM

	Unknown Object (File)
	Tue, Apr 30, 10:09 PM

	Unknown Object (File)
	Tue, Apr 30, 5:14 PM

	Unknown Object (File)
	Tue, Apr 30, 5:14 PM

	Unknown Object (File)
	Tue, Apr 30, 5:14 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T7756: Conpherence threads should support monograms

Commits

Restricted Diffusion Commit
rP295308de5bd8: Conpherence - turn on mentions interface for Conpherence rooms / messages

Summary

Fixes T7756. This is the last little stray bit, though finishing T7757 also helps this feature IMO.

Test Plan

said "ZXX is the best" in comment on DXX and saw proper mention transaction on ZXX

Diff Detail

Repository

Branch

T7756

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5305
Build 5323: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 29799.Apr 13 2015, 11:32 PM

btrahan added a task: T7756: Conpherence threads should support monograms.

btrahan retitled this revision from to Conpherence - turn on mentions interface for Conpherence rooms / messages.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 13 2015, 11:32 PM

btrahan added inline comments.Apr 13 2015, 11:32 PM

src/applications/conpherence/view/ConpherenceTransactionView.php
134–136	stray!
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
224–226	low level support seemed appropriate for this. other implementers all picked it up for free via project interface.

remove debugging code

epriestley accepted this revision.Apr 14 2015, 12:07 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 14 2015, 12:07 AM

Closed by commit rP295308de5bd8: Conpherence - turn on mentions interface for Conpherence rooms / messages (authored by btrahan, committed by btrahan). · Explain WhyApr 14 2015, 1:12 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

storage/

ConpherenceThread.php

1 line

view/

ConpherenceTransactionView.php

1 line

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

3 lines

Diff 29800

src/applications/conpherence/storage/ConpherenceThread.php

Loading...

src/applications/conpherence/view/ConpherenceTransactionView.php

Loading...

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...