Page MenuHomePhabricator
Differential D12377

Add a linter rule for lowercase function names
ClosedPublic
Actions

Authored by joshuaspence on Apr 12 2015, 9:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 30, 6:14 PM
Unknown Object (File)
Tue, Dec 24, 4:29 PM
Unknown Object (File)
Tue, Dec 17, 9:42 AM
Unknown Object (File)
Dec 8 2024, 12:38 AM
Unknown Object (File)
Nov 22 2024, 11:42 AM
Unknown Object (File)
Nov 22 2024, 11:27 AM
Unknown Object (File)
Nov 19 2024, 12:11 PM
Unknown Object (File)
Oct 26 2024, 9:12 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7409: Implement PHPCS lints
Commits
rARCab4eac6f3180: Add a linter rule for lowercase function names
Summary

Ref T7409. Adds ArcanistXHPASTLinter::LINT_LOWERCASE_FUNCTIONS to ensure that builtin PHP functions are lowercased. Based on Squiz_Sniffs_PHP_LowercasePHPFunctionsSniff.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5263
Build 5281: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29709.Apr 12 2015, 9:20 PM
joshuaspence retitled this revision from to Add a linter rule for lowercase function names.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7409: Implement PHPCS lints.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 12 2015, 9:20 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 12 2015, 9:20 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 12 2015, 9:20 PM
joshuaspence updated this revision to Diff 30019.Apr 22 2015, 12:06 PM
joshuaspence edited edge metadata.

Rebase

Closed by commit rARCab4eac6f3180: Add a linter rule for lowercase function names (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 22 2015, 12:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
39 lines
__tests__/
xhpast/
9 lines

Diff 29709

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/lowercase-functions.lint-test

Loading...
Phabricator · Built by Phacility