Paths

Table of Contentst

Differential D12377

Add a linter rule for lowercase function names
ClosedPublic
Actions

Authored by joshuaspence on Apr 12 2015, 9:20 PM.

Tags

None

Referenced Files

	F14788747: D12377.diff
	Fri, Jan 24, 6:01 PM

	F14775023: D12377.id30021.diff
	Fri, Jan 24, 2:29 AM

	F14775021: D12377.id30019.diff
	Fri, Jan 24, 2:29 AM

	F14775020: D12377.id29709.diff
	Fri, Jan 24, 2:29 AM

	F14775018: D12377.id.diff
	Fri, Jan 24, 2:29 AM

	F14775017: D12377.diff
	Fri, Jan 24, 2:29 AM

	Unknown Object (File)
	Tue, Jan 21, 4:06 PM

	Unknown Object (File)
	Tue, Jan 21, 3:18 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7409: Implement PHPCS lints

Commits

rARCab4eac6f3180: Add a linter rule for lowercase function names

Summary

Ref T7409. Adds ArcanistXHPASTLinter::LINT_LOWERCASE_FUNCTIONS to ensure that builtin PHP functions are lowercased. Based on Squiz_Sniffs_PHP_LowercasePHPFunctionsSniff.

Test Plan

Added unit tests.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 5435
Build 5453: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	1,287 ms	ArcanistPuppetLintLinterTestCase::testLinter
	921 ms	ArcanistCSSLintLinterTestCase::testLinter
	182 ms	ArcanistCSSLintLinterTestCase::testVersion
	190 ms	ArcanistChmodLinterTestCase::testLinter
	281 ms	ArcanistClosureLinterTestCase::testLinter
		View Full Test Results (1 Failed · 48 Passed · 4 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 29709.Apr 12 2015, 9:20 PM

joshuaspence retitled this revision from to Add a linter rule for lowercase function names.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T7409: Implement PHPCS lints.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 12 2015, 9:20 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 12 2015, 9:20 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 12 2015, 9:20 PM

Rebase

Closed by commit rARCab4eac6f3180: Add a linter rule for lowercase function names (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 22 2015, 12:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

41 lines

__tests__/

xhpast/

lowercase-functions.lint-test

9 lines

Diff 30019

src/lint/linter/ArcanistXHPASTLinter.php

Loading...

src/lint/linter/tests/xhpast/lowercase-functions.lint-test

Loading...