Page MenuHomePhabricator
Differential D12377

Add a linter rule for lowercase function names
ClosedPublic
Actions

Authored by joshuaspence on Apr 12 2015, 9:20 PM.
Tags
None
Referenced Files
F18212325: D12377.id30019.diff
Tue, Aug 19, 2:56 AM
F18212324: D12377.id29709.diff
Tue, Aug 19, 2:55 AM
F18078904: D12377.id29709.diff
Mon, Aug 4, 8:31 PM
F18078247: D12377.id30019.diff
Mon, Aug 4, 7:58 PM
F18067748: D12377.id.diff
Mon, Aug 4, 2:58 PM
F18057027: D12377.id30021.diff
Mon, Aug 4, 8:52 AM
F18051348: D12377.diff
Sun, Aug 3, 10:55 PM
F17804916: D12377.id29709.diff
Fri, Jul 25, 11:58 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7409: Implement PHPCS lints
Commits
rARCab4eac6f3180: Add a linter rule for lowercase function names
Summary

Ref T7409. Adds ArcanistXHPASTLinter::LINT_LOWERCASE_FUNCTIONS to ensure that builtin PHP functions are lowercased. Based on Squiz_Sniffs_PHP_LowercasePHPFunctionsSniff.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5263
Build 5281: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29709.Apr 12 2015, 9:20 PM
joshuaspence retitled this revision from to Add a linter rule for lowercase function names.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7409: Implement PHPCS lints.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 12 2015, 9:20 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 12 2015, 9:20 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 12 2015, 9:20 PM
joshuaspence updated this revision to Diff 30019.Apr 22 2015, 12:06 PM
joshuaspence edited edge metadata.

Rebase

Closed by commit rARCab4eac6f3180: Add a linter rule for lowercase function names (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 22 2015, 12:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
39 lines
__tests__/
xhpast/
9 lines

Diff 29709

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/lowercase-functions.lint-test

Loading...
Phabricator · Built by Phacility