Fix "To: Unknown Object" on outbound Maniphest mail with no owner
ClosedPublic
Actions

Authored by epriestley on Apr 8 2015, 12:16 PM.

Details

Reviewers

joshuaspence
btrahan

Maniphest Tasks

T7778: "Unknown Object (????)" in outbound email

Commits

Restricted Diffusion Commit
rP13c0c3b850ea: Fix "To: Unknown Object" on outbound Maniphest mail with no owner

Summary

Fixes T7778. This was likely caused by removing an array_filter() somewhere in the course of T7731, but I'd rather have the code be more correct.

Test Plan

Sent mail on a task with no owner.

Before patch: unknown recipient.
After patch: expected recipients.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29601.Apr 8 2015, 12:16 PM

epriestley retitled this revision from to Fix "To: Unknown Object" on outbound Maniphest mail with no owner.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, joshuaspence.

epriestley added a task: T7778: "Unknown Object (????)" in outbound email.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 8 2015, 12:16 PM

joshuaspence accepted this revision.Apr 8 2015, 12:20 PM

joshuaspence edited edge metadata.

This revision is now accepted and ready to land.Apr 8 2015, 12:20 PM

Closed by commit rP13c0c3b850ea: Fix "To: Unknown Object" on outbound Maniphest mail with no owner (authored by epriestley, committed by epriestley). · Explain WhyApr 8 2015, 12:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

editor/

ManiphestTransactionEditor.php

12 lines

Diff 29602

View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Fix "To: Unknown Object" on outbound Maniphest mail with no ownerClosedPublicActions